Skip to content

docs(skills): improve drafting skills from signal log patterns 2026-08-05 - #478

Merged
hongyi-chen merged 2 commits into
mainfrom
docs/improve-drafting-skills-2026-08-05
Aug 5, 2026
Merged

docs(skills): improve drafting skills from signal log patterns 2026-08-05#478
hongyi-chen merged 2 commits into
mainfrom
docs/improve-drafting-skills-2026-08-05

Conversation

@oz-by-warp

@oz-by-warp oz-by-warp Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Patterns addressed

Signal window: last 30 days (through 2026-08-05). Primary source: GitHub human review comments and verdicts on agent-coauthored merged PRs, plus the durable log on chore/drafting-signal-logs. Oz run style-lint and pr-review signal markers were not present in title-matched runs from oz run list --limit 100 (CLI has no pagination cursor on this build).

  1. missing_media / screenshots for visual UI (human feedback: review comments across 6 PRs, including docs: Warp Agent CLI launch documentation #411, docs(cli): cloud handoff and orchestration #402, docs: publish Jira integration page with self-serve setup flow #338, docs(APP-4267): add Mermaid diagrams section to Markdown Viewer #305)

    • Reviewers repeatedly asked to add screenshots for surfaces agents described only in prose (statusline chips, Agents tab bar, settings chrome).
    • Existing rules covered alt text and “don’t screenshot the obvious,” but not when a screenshot is required.
    • Signal type: repeated human review comment across multiple PRs (threshold: 2+ PRs).
  2. VideoEmbed title prop (human + template gap; guide template previously omitted title)

Improvement targets

  • .agents/skills/draft_docs/SKILL.md — additive Critical formatting rules + checklist items for screenshot inclusion and VideoEmbed titles (shared by all drafting skills)
  • .agents/templates/feature-doc.md — bracket instruction to place screenshots after the prose that introduces distinctive visual surfaces
  • .agents/templates/guide-page.md — require a specific title prop on the scaffolded VideoEmbed (or remove the block)

Patterns reviewed but not acted on

Open questions for human review

  1. Is “screenshot or explicit note that none is available yet” the right bar for agent-authored PRs when the agent cannot capture UI in CI?
  2. Should style_lint grow a video_embed_title check so title-less embeds fail automatically, or is the skill/template guidance enough?

Test plan

  • git diff --check clean
  • YAML frontmatter parse check on changed skill/template files
  • Diff limited to .agents/skills/ and .agents/templates/
  • Edits are additive (no removals of existing rules)

Related

@cla-bot cla-bot Bot added the cla-signed label Aug 5, 2026
@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 5, 2026 7:37pm

Request Review

@hongyi-chen
hongyi-chen marked this pull request as ready for review August 5, 2026 19:34
@hongyi-chen
hongyi-chen merged commit ee46667 into main Aug 5, 2026
6 of 7 checks passed
@oz-for-oss

oz-for-oss Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@hongyi-chen

I'm starting a first review of this pull request.

I cancelled the in-progress review run because this pull request was closed.

Powered by Oz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants