docs(skills): improve drafting skills from signal log patterns 2026-08-05 - #478
Merged
Merged
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hongyi-chen
approved these changes
Aug 5, 2026
hongyi-chen
marked this pull request as ready for review
August 5, 2026 19:34
Contributor
|
I'm starting a first review of this pull request. I cancelled the in-progress review run because this pull request was closed. Powered by Oz |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patterns addressed
Signal window: last 30 days (through 2026-08-05). Primary source: GitHub human review comments and verdicts on agent-coauthored merged PRs, plus the durable log on
chore/drafting-signal-logs. Oz run style-lint and pr-review signal markers were not present in title-matched runs fromoz run list --limit 100(CLI has no pagination cursor on this build).missing_media / screenshots for visual UI (human feedback: review comments across 6 PRs, including docs: Warp Agent CLI launch documentation #411, docs(cli): cloud handoff and orchestration #402, docs: publish Jira integration page with self-serve setup flow #338, docs(APP-4267): add Mermaid diagrams section to Markdown Viewer #305)
VideoEmbed title prop (human + template gap; guide template previously omitted
title)AGENTS.mdalready requires a specifictitleon everyVideoEmbed, butguide-page.mdscaffolded embeds withouttitle, and step 6.5 had no concrete good/bad example.Improvement targets
.agents/skills/draft_docs/SKILL.md— additive Critical formatting rules + checklist items for screenshot inclusion andVideoEmbedtitles (shared by all drafting skills).agents/templates/feature-doc.md— bracket instruction to place screenshots after the prose that introduces distinctive visual surfaces.agents/templates/guide-page.md— require a specifictitleprop on the scaffoldedVideoEmbed(or remove the block)Patterns reviewed but not acted on
Open questions for human review
style_lintgrow avideo_embed_titlecheck so title-less embeds fail automatically, or is the skill/template guidance enough?Test plan
git diff --checkclean.agents/skills/and.agents/templates/Related